This project is archived and is in readonly mode.

#3035 ✓invalid
Luis Villa

auto_link in text_helper.rb doesn't handle some gmail URLS

Reported by Luis Villa | August 11th, 2009 @ 03:43 AM

gmail URLs (and increasingly other URLs as well) can have important information after an anchor, such as:

https://mail.google.com/mail/#search/%7Bis%3Aunread+is%3Astarred+is...
aft%7D/12272188ec71e0f4

auto_link does not love this URL, only autolinking the \w trailing the # and not everything after that next /, i.e., you get:

https://mail.google.com/mail/#search [linked]

/%7Bis%3Aunread+is%3Astarred+is%3Adraft%7D/12272188ec71e0f4 [plain text, not linked]

I noticed this in an older version of rails, but looking at git it seems that the regexp at issue is the same in both my older version and in current trunk.

Michael, my apologies if you're not actually responsible, but I saw in bug #1353 and others that you have touched/reviewed patches to this code, so thought you might be closest. Thanks.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Pages