This project is archived and is in readonly mode.
auto_link in text_helper.rb doesn't handle some gmail URLS
Reported by Luis Villa | August 11th, 2009 @ 03:43 AM
gmail URLs (and increasingly other URLs as well) can have important information after an anchor, such as:
https://mail.google.com/mail/#search/%7Bis%3Aunread+is%3Astarred+is...
aft%7D/12272188ec71e0f4
auto_link does not love this URL, only autolinking the \w trailing the # and not everything after that next /, i.e., you get:
https://mail.google.com/mail/#search [linked]
/%7Bis%3Aunread+is%3Astarred+is%3Adraft%7D/12272188ec71e0f4 [plain text, not linked]
I noticed this in an older version of rails, but looking at git it seems that the regexp at issue is the same in both my older version and in current trunk.
Michael, my apologies if you're not actually responsible, but I saw in bug #1353 and others that you have touched/reviewed patches to this code, so thought you might be closest. Thanks.
Comments and changes to this ticket
-
CancelProfileIsBroken September 25th, 2009 @ 12:54 PM
- Tag changed from “auto_link, text_helper” to “auto_link, bugmash, text_helper”
- Assigned user cleared.
-
Robert Rouse September 26th, 2009 @ 01:05 AM
I'm unable to actually reproduce this one. I tried various urls from Gmail.
-
Elad Meidar September 26th, 2009 @ 02:51 AM
Close this ticket, tried several urls and they all pass.
attached a test to check this specific example, it passes on 2-3-stable
-
-
Elomar França September 26th, 2009 @ 04:45 PM
-1, can't reproduce. The tests from Elad Meidar passes on 2-3-stable and master.
-
Pat Allan September 26th, 2009 @ 05:16 PM
- Tag changed from “auto_link, bugmash, text_helper” to “auto_link, bugmash, bugmash-review, text_helper”
And -1 from me too, along with Elad's tests passing. I think it's safe to close this (Luis, do you disagree?)
-
sr.iniv.t September 26th, 2009 @ 05:47 PM
-1 not reproducible.
Elad's test passes in 2-3-stable for me too.
-
CancelProfileIsBroken September 27th, 2009 @ 11:50 AM
- State changed from “new” to “invalid”
- Tag changed from “auto_link, bugmash, bugmash-review, text_helper” to “auto_link, text_helper”
-
CancelProfileIsBroken September 27th, 2009 @ 12:33 PM
- Tag changed from “auto_link, text_helper” to “auto_link, bugmash, text_helper”
-
Matías Flores September 27th, 2009 @ 07:25 PM
-1 not reproducible
Applied Elad Meidar's patch in both 2-3-stable and master and in both branches all tests passed as expected.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
CancelProfileIsBroken
Michael Koziarski