This project is archived and is in readonly mode.
Spaces at end of association :order options causes error
#1388
Out of habit, I've been using spaces around all :condition and :order strings in my has_many associations. SQL doesn't mind extra spaces and I always fear a string being joined without a space causing some unforseen error.
ActiveRecord::Base#reverse_sql_order, though, causes an error for me when calling some_has_many_association.last for an association that has an :order option that ends in " asc " by adding an extra "DESC" to the order string of the query.
Adding a check for spaces to the regexes of reverse_sql_order fixes it for me. See patch...
-
Pratik- Tag changed from :order, activerecord, associations, has_many to :order, activerecord, associations, has_many, patch
- Title changed from PATCH: spaces at end of association :order options causes error to Spaces at end of association :order options causes error
-
Pratik
- State changed from new to wontfix
I don't think using spaces is normal. Closing the ticket as it all works fine when no spaces are used. Don't think it's worth complicating.
Thanks.