John Devine's profile - rails

Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

John Devine's latest activity

Thursday, March 19 2009

1528 Only join includes referenced in conditions for count was updated in Ruby on Rails

John Devine commented at 10:37 PM
I'll see if I can come up with some tests this weekend -- but I've never done a test for a specific SQL statement. Since nothing's actually broken (in terms of ...

Monday, December 08 2008

1528 [PATCH] only join includes referenced in conditions for count was created in Ruby on Rails

John Devine created the ticket at 5:38 AM
When issuing ActiveRecord.count queries, include options are now turned into joins indiscriminately. This patch copies the strategy from associations.rb constru...

Sunday, November 16 2008

1388 PATCH: spaces at end of association :order options causes error was created in Ruby on Rails

John Devine created the ticket at 11:47 PM
Out of habit, I've been using spaces around all :condition and :order strings in my has_many associations. SQL doesn't mind extra spaces and I always fear a str...

Friday, August 22 2008

887 link_to_remote options[:position] was created in Ruby on Rails

John Devine created the ticket at 8:56 PM

including :position=>:bottom in the options now results in a javascript error for me in edge. {:position=>"'bottom'"} works.

Not sure if it's something I chang...

Sunday, May 04 2008

110 [PATCH] Scan custom select to ensure included tables are joined was updated in Ruby on Rails

John Devine commented at 8:11 PM
added test
John Devine created the ticket at 8:11 PM
Came across this when using GeoKit to inject a derived distance attribute into an active record when the distance was calculated by the lat/lon of an associate...

109 [patch] Ensure necessary included tables are joined in construct_finder_sql_f... was created in Ruby on Rails

John Devine created the ticket at 7:25 PM
Currently selecting limited ids for eager loading associations is broken when there is a condition or an order-by based on a table that is not directly joined ...