This project is archived and is in readonly mode.
MASSIVE memory leak in AssetTag
Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released.
If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak.
The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -> "/stylesheets/foo.css"
The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative.
-
stop_asset_tag_memory_leak.diff
6.13 KB
-
Jeremy Kemper- State changed from new to open
- Assigned user set to josh
- Milestone cleared.
-
Michael KoziarskiChange looks good to me, josh?
-
aaronbatalionWrote a quick blog post explaining the issue in more detail. http://blog.hungrymachine.com/20...
Also, I believe AssetTagCollection has the same problem, and isnt covered in my patch.
-
aaronbatalion
Attached is an updated patch that accounts for the assettag type being included in the cache key. Including the name of the class is better than self itself, against for hard references.
Also added a failing test that now passes.
-
joshah, I hate this cache. I should def look into preloading the asset folder contents on boot.
-
Repository
- State changed from open to resolved
(from [24dbd4b9581ba2affef9e8e96570200ee1e3266c]) Fixed asset host to not cache objects [#1419 MASSIVE memory leak in AssetTag state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
-
Repository
(from [d7f4921a9a852da7c1075275eaf73822edb7acff]) Fixed asset host to not cache objects [#1419 MASSIVE memory leak in AssetTag state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
-
aaronbatalion
Josh, Please commit the 2nd patch. I found a bug that will mix js/css files and cache them as the same keys. This bug is still open.
-
-
Jeremy Kemper
applied