#1427 ActionView::Base.default_form_builder - Ruby on Rails

+1 for moving cattr_accessor :default_form_builder - it's kind of public api, so it should be moved and documented. Initializing it should stay IMO in form_helper.rb.

November 21st, 2008 @ 12:24 PM

Pratik

Assigned user set to Pratik
State changed from new to incomplete

Sounds good. Patch please! Also, the old API needs to be deprecated.

Thanks.

March 10th, 2009 @ 11:58 AM

beawesomeinstead

Something like this?

moved-accessor-to-action_mailer-base_rb.diff 2 KB

January 21st, 2010 @ 05:12 PM

beawesomeinstead

Assigned user changed from Pratik to José Valim

Better version.

moved-accessor-to-action_mailer-base_rb-v2.diff 1.98 KB

January 22nd, 2010 @ 05:01 AM

Prem Sichanugrist (sikachu)

Tag changed from actionpack, edge, form, form_helper to actionpack, edge, form, form_helper, review

January 22nd, 2010 @ 08:32 AM

José Valim

We need some deprecation warning on this.

January 25th, 2010 @ 12:08 AM

José Valim

Is someone working on a new patch with deprecation warnings on this? :)

February 2nd, 2010 @ 09:16 AM

Prem Sichanugrist (sikachu)

I'm bugging beawesomeinstead in the chat room now. he's going to upload it here soon

February 2nd, 2010 @ 09:19 AM

beawesomeinstead

Oops, sorry for the delay, we've had a new release last week. Patch attached.

moved-accessor-to-action_mailer-base_rb-v3.diff 2.77 KB

February 2nd, 2010 @ 09:39 AM

José Valim

State changed from incomplete to wontfix

I had some issues applying the patch and running an application, it made the FormBuilder constant be loaded too early. The bottom of form_helper.rb is indeed the proper place for it. Sorry mate for making you fix the patch twice.

February 2nd, 2010 @ 10:07 AM

beawesomeinstead

np :-) wontfix is better than open :-)

February 2nd, 2010 @ 10:54 AM