This project is archived and is in readonly mode.
ActionView::Base.default_form_builder
Reported by qoobaa | November 21st, 2008 @ 11:39 AM | in 2.x
The accessor is defined (and initialized) in quite non-obvious place - at the end of the actionpack/lib/action_view/helpers/form_helper.rb file.
I'd suggest moving it to actionpack/lib/action_view/base.rb and documenting since it's being used by plugins like fudge_form.
Comments and changes to this ticket
-
Jacek Becela November 21st, 2008 @ 12:24 PM
+1 for moving cattr_accessor :default_form_builder - it's kind of public api, so it should be moved and documented. Initializing it should stay IMO in form_helper.rb.
-
Pratik March 10th, 2009 @ 11:58 AM
- Assigned user set to “Pratik”
- State changed from “new” to “incomplete”
Sounds good. Patch please! Also, the old API needs to be deprecated.
Thanks.
-
-
beawesomeinstead January 22nd, 2010 @ 05:01 AM
- Assigned user changed from “Pratik” to “José Valim”
Better version.
-
Prem Sichanugrist (sikachu) January 22nd, 2010 @ 08:32 AM
- Tag changed from “actionpack, edge, form, form_helper” to “actionpack, edge, form, form_helper, review”
-
-
José Valim February 2nd, 2010 @ 09:16 AM
Is someone working on a new patch with deprecation warnings on this? :)
-
Prem Sichanugrist (sikachu) February 2nd, 2010 @ 09:19 AM
I'm bugging
beawesomeinsteadin the chat room now. he's going to upload it here soon -
beawesomeinstead February 2nd, 2010 @ 09:39 AM
Oops, sorry for the delay, we've had a new release last week. Patch attached.
-
José Valim February 2nd, 2010 @ 10:07 AM
- State changed from “incomplete” to “wontfix”
I had some issues applying the patch and running an application, it made the FormBuilder constant be loaded too early. The bottom of form_helper.rb is indeed the proper place for it. Sorry mate for making you fix the patch twice.
-
-
Ryan Bigg November 8th, 2010 @ 01:49 AM
- Tag cleared.
- Importance changed from “” to “Low”
Automatic cleanup of spam.
-
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Jeremy Kemper
José Valim
Pratik
Prem Sichanugrist (sikachu)
Ryan Bigg