This project is archived and is in readonly mode.
Join tables referenced by :group when eager loading
For the rewrite of eager loading for 2.1, checks were put in place to join association tables in the old manner if they were referenced by :select, :order or :conditions. For some reason, :group was left out. Here is a patch to address this.
-
include_eager_group.patch
3.63 KB
-
James Le CuirotHere's a patch against 2.1 for anyone that needs it.
-
include_eager_group-2-1.patch
3.63 KB
-
-
Pratik- Assigned user set to Frederick Cheung
-
Gabe da Silveira- Tag changed from 2.1, eager_loading, edge, group, include, join, patch to 2.1, bugmash, eager_loading, edge, group, include, join, patch
Tagging this one bugmash since Pratik suggested it to me (he knows how much I love these eager loading issues).
-
Gabe da Silveira
- Tag changed from 2.1, bugmash, eager_loading, edge, group, include, join, patch to 2.1, bugmash, eager_loading, edge, group, include, join, patch, verified
verified the test case against 2-3-stable. I rebased the patch, and it fixed the problem for mysql, but raised two different errors in sqlite and pgsql. This is a deeper problem, but I think the initial patch is correct, just need to identify the underlying issues. Here is my rebased version on 2-3 which passes for mysql but fails for sqlite and postgres. I'll pick this up later if no one else does.
I've attached a patch.
-
partial-fix-for-2-3.diff
4.66 KB
-
James Le Cuirot
I realised shortly after posting this that I didn't actually need it and I could approach the problem in a better way. I've forgotten the details though. I doubt many people would need this to be fixed but it could be worth doing just for completeness.
-
Rizwan Reza- State changed from new to invalid
- Tag changed from 2.1, bugmash, eager_loading, edge, group, include, join, patch, verified to 2.1, eager_loading, edge, group, include, join, patch, verified