This project is archived and is in readonly mode.
Deprecations and dependencies logger and controller failsafe_logger errors
-
Frederick Cheung
I've patched this and verified it works. Re: test coverage the issue is that tests override the logging to the log file behaviour (in favour of something that makes it easier to assert that the correct deprecation warning was issued)
-
Rob Anderton
- Tag changed from actioncontroller, active_support, bug to actioncontroller, active_support, bug, patch
+1 That works for me, thanks.
Again, apologies for not patching this myself - not being lazy (honest!) just too many pre-christmas deadlines to worry about right now :D
-
josh
- Milestone cleared.
- Assigned user set to josh
- State changed from new to open
-
Repository
- State changed from open to resolved
(from [7c18518105e98ccfd89fe64194ede27824dfe8b3]) Properly parenthasize calls to defined?(Rails) in 75fa82418 [#1563 Deprecations and dependencies logger and controller failsafe_logger errors state:resolved] Signed-off-by: Joshua Peek josh@joshpeek.com http://github.com/rails/rails/co...
