This project is archived and is in readonly mode.

#1563 ✓resolved
Rob Anderton

Deprecations and dependencies logger and controller failsafe_logger errors

Reported by Rob Anderton | December 11th, 2008 @ 11:29 PM

The lack of parentheses in the calls to defined? in this commit is causing problems when logging deprecations, for example, the ActiveModel errors class tries to warn about deprecation and causes this error:

private method warn' called for [expression](String)

The backtrace points to:


Adding parentheses to this line fixes the problem:

logger = defined?(Rails) ? Rails.logger :$stderr)

Similar changes are also needed in the other files touched by this commit - the fact that this wasn't picked up in the tests also suggests a hole in coverage :)

Sorry I haven't got time to put together a patch, but this should be a fairly quickfix anyway.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by