This project is archived and is in readonly mode.

#1623 ✓invalid
Jeff Cohen

Automatically invoke Update task after freezing to gems

Reported by Jeff Cohen | December 23rd, 2008 @ 10:04 PM | in 2.x

The rails:freeze:edge task will automatically invoke rails:update, but rails:freeze:gems does not.

This patch calls rails:update at the end of rails:freeze:gems, to make sure that scripts are in sync with the newly-frozen version of rails.

Motivated by the fact that I got into trouble after freezing to a previous version of Rails, but I forgot the manual step of running rake rails:update and things went a bit haywire for a while until I figured it out.

Comments and changes to this ticket

  • Ben Reubenstein
  • Brian Hogan

    Brian Hogan December 31st, 2008 @ 04:30 AM

    +1

    It may not be necessary but it's inconsistent and that's what bugs me.

  • Pratik

    Pratik March 8th, 2009 @ 12:50 AM

    • Assigned user set to “Pratik”
    • State changed from “new” to “invalid”

    I don't think this makes much sense. When you run rails:freeze:edge, you're updating the rails itself. But when you rails:freeze:gems, you're not really updating Rails. rails:freeze:gems will/should update frozen rails gems only if you manually change RAILS_GEM_VERSION in env.rb. But that process is irrelevant to rails:freeze:gems and the processes of freezing/upgrading Rails shouldn't be mixed in case of freezing gems.

    Thanks.

  • klkk

    klkk May 23rd, 2011 @ 03:14 AM

    • Importance changed from “” to “”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Tags

Pages