Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jeff Cohen

Jeff Cohen

Not a member

Jeff Cohen's latest activity

Tuesday, January 13 2009
1743 Fix --freeze option was updated in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen commented at 3:30 PM

    Hmmm, maybe I misunderstood. I see now that you're supposed to use the -f after you specify the appname; I thought it was supposed to come before.

    Feel free to ...
  • Jeff Cohen
    Jeff Cohen commented at 2:42 AM

    Ugh, formatting messed up. The error I would get would be:

    /Library/Ruby/Gems/1.8/gems/rails-2.2.2/bin/rails:23:in `chdir': can't convert nil into String (Type...
  • Jeff Cohen
    Jeff Cohen created the ticket at 2:39 AM

    I recently discovered the --freeze option when I was reading some of the source code. Unfortunately I also discovered that it appears to have never worked corre...
Monday, January 05 2009
1625 Allow active record errors to_xml to return separate tags for attribute and m... was updated in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen commented at 8:16 PM

    I like this idea. However, I might suggest that the content be the same as it was before in the field. For example, instead of:

    
  <attribute>name</attribute>...
Tuesday, December 23 2008
1623 Automatically invoke Update task after freezing to gems was created in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen created the ticket at 10:04 PM

    The rails:freeze:edge task will automatically invoke rails:update, but rails:freeze:gems does not.

    This patch calls rails:update at the end of rails:freeze:gems...
Thursday, November 13 2008
1145 Bug: InvalidAuthenticityToken incorrectly raised for XML controller#destroy r... was updated in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen commented at 1:48 PM

    Thanks everyone!

    I'm glad this not only got fixed, but it was certainly a community effort to get it done, which I personally think is pretty cool :-)

    Jeff
Saturday, November 01 2008
1145 Bug: InvalidAuthenticityToken incorrectly raised for XML controller#destroy r... was updated in Ruby on Rails
  • Jeff Cohen
    • Tag changed from actionpack, activeresource, bug, request-forgery-protection to actionpack, activeresource, bug, patch, request-forgery-protection
    by Jeff Cohen at 4:53 AM

    Ok, patch attached. Here's the final summary:

    • Changed Mime::Type#verify_request? to only worry about HTML-formatted content.
    • Only HTML and Ajax requests that a...
Friday, October 31 2008
1145 Bug: InvalidAuthenticityToken incorrectly raised for XML controller#destroy r... was updated in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen commented at 2:23 PM

    Running into one annoyance, which is that the tests don't seem to set the default content type to html. So tests like this,

    
  def test_should_not_allow_post_...
  • Jeff Cohen
    Jeff Cohen commented at 2:06 AM

    Ok, I think I'm almost there, but I have a question about what we want to do with existing tests that no longer seem valid. Do I delete them, or change the asse...
Wednesday, October 29 2008
1145 Bug: InvalidAuthenticityToken incorrectly raised for XML controller#destroy r... was updated in Ruby on Rails
  • Jeff Cohen
    Jeff Cohen commented at 12:23 AM

    Trying Mathjis's suggestion:

    !request.content_type.nil? && request.content_type.verify_request?

    did not work - it broke a lot of existing tests that expected ex...