This project is archived and is in readonly mode.
Fix --freeze option
I recently discovered the --freeze option when I was reading some of the source code. Unfortunately I also discovered that it appears to have never worked correctly. I would always get an error like this:
/Library/Ruby/Gems/1.8/gems/rails-2.2.2/bin/rails:23:in
chdir': can't convert nil into String (TypeError)
from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/bin/rails:23
from /usr/bin/rails:19:in `load'
from /usr/bin/rails:19
This patch fixes it. Now you can do:
rails -f hello
and the app will be frozen to gems.
No idea how to test this other than some ad-hoc testing.
-
fix-freeze-option.diff
1.17 KB
-
Jeff CohenUgh, formatting messed up. The error I would get would be:
/Library/Ruby/Gems/1.8/gems/rails-2.2.2/bin/rails:23:in `chdir': can't convert nil into String (TypeError) from /Library/Ruby/Gems/1.8/gems/rails-2.2.2/bin/rails:23 from /usr/bin/rails:19:in `load' from /usr/bin/rails:19 -
Pratik- Milestone cleared.
- Assigned user set to Pratik
-
Matt Jones
Not really solving the problem here - note that 'rails appname --freeze' will work with the current code. The problem is that the option parsing code in app_generator.rb is much smarter than the code in the rails executable.
Maybe there should be an accessor for app_name on AppGenerator?
-
Chris SepicFreezing currently works with the option after the path:
rails appname -f
However
rails -f appname
makes more sense to me.
+1
-
Jeff Cohen
Hmmm, maybe I misunderstood. I see now that you're supposed to use the -f after you specify the appname; I thought it was supposed to come before.
Feel free to close this as invalid if I misunderstood the desired behavior.
-
Pratik
- State changed from new to invalid