#1639 Adds an :on option to ActiveRecord observers - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1639 open

Adds an :on option to ActiveRecord observers

Reported by Gabriel Gironda | December 26th, 2008 @ 09:58 PM | in 3.0.6

I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling observe twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the observe method to not clear out models from previous declarations

observer_on_option.diff 7 KB

Comments and changes to this ticket

You flagged this item as spam.
Bryan Liles December 27th, 2008 @ 01:12 AM
The would read much better if you could do:

observe :comment, :photo, :after => :create

-or-

observe :comment, :photo, :on => [:create, :update]
You flagged this item as spam.
Gabriel Gironda December 27th, 2008 @ 01:24 AM
Thanks for the comments, Bryan!

The former, I agree with. When I get a moment I'll add that functionality to the patch.

The latter would be a problem because there's cases where you might want before_update rather than after_update. Defaulting it to use after_ by convention would cause problems in the case where a custom callback is being used - notify(:before_some_domain_specific_event) in your models, for example.
You flagged this item as spam.
Gabriel Gironda January 27th, 2009 @ 10:45 PM
Here's a new patch that adds the :after => :create kind of syntax.
- observer_on_option.diff 7.6 KB
CancelProfileIsBroken August 4th, 2009 @ 06:14 PM
- Tag changed from “patch” to “bugmash, patch”
Dan Pickett August 8th, 2009 @ 10:44 PM
+1 this is nice syntax

having trouble applying the patch - will try to apply to master and modify as necessary
Rizwan Reza January 20th, 2010 @ 11:11 AM
- Milestone cleared.
- Tag changed from “bugmash, patch” to “activerecord, observers, patch”
- State changed from “new” to “open”
- Assigned user set to “Pratik”
Jeremy Kemper August 30th, 2010 @ 04:10 AM
- Milestone cleared.
- Importance changed from “” to “”
[bulk edit]
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]
Jeff Kreeftmeijer November 8th, 2010 @ 08:48 AM
- Tag cleared.
Automatic cleanup of spam.
Santiago Pastorino November 15th, 2010 @ 09:04 PM
- Milestone cleared.
[bulk edit]
Santiago Pastorino February 12th, 2011 @ 09:58 PM
- Milestone set to “3.0.5”
[bulk edit]
Santiago Pastorino February 27th, 2011 @ 03:15 AM
- Milestone changed from “3.0.5” to “3.0.6”
[bulk edit]