Inappropriate "@variable will no longer be implicitly assigned to variable" message

Seems that deprecation notice is causing alot of false negatives.

Maybe we should just remove it? Unless someone has a proper fix.

Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.

Automatic cleanup of spam.

Okay, I finally managed to reproduce this. The key fact is that the passed local assign needs to be nil, otherwise the proxy object isn't created. We can fix this by checking to see if the local assigns has a key for :object or the variable name and not creating the proxy object if it exists. Steps to reproduce:

# app/controllers/pages_controller.rb
class PagesController < ApplicationController
  def index
    @message = "Foo"
  end
end

# app/views/pages/_message.html.erb
<%= h message %>

# 1. This will raise a deprecation warning in index.html.erb
<%= render :partial => 'message', :locals => { :message => nil } %>

# 2. This will raise a deprecation warning in index.html.erb
<%= render :partial => 'message' %>

# 3. This will not raise a deprecation warning in index.html.erb
<%= render :partial => 'message', :locals => { :message => "Bar" } %>

Adding the check for the key in local assigns will fix example 1 but example 2 will still raise the error which is what's desired. Performance impact should be negligible since most of the time the conditional will be short-circuited.

(from [0e52a609fd38856100ef5ab4ce8fe1207e417eca]) Don't create a deprecation proxy object if the variable was passed in local_assigns [#1671 Inappropriate "@variable will no longer be implicitly assigned to variable" m... state:resolved] http://github.com/rails/rails/commit/0e52a609fd38856100ef5ab4ce8fe1...