#181 Incorrect input name with nested fields_for - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#181 ✓duplicate

Incorrect input name with nested fields_for

Reported by David Röthlisberger | May 13th, 2008 @ 04:36 PM | in 2.x

form_for('post[]', @post) do |f|
  f.fields_for('comment[]', @comment) do |c|
    c.text_field(:name)
  end
end

I expect:

<input name="post[123][comment][][name]" .../>

Instead I get:

<input name="post[][comment[]][name]" .../>

Comments and changes to this ticket

David Röthlisberger May 13th, 2008 @ 04:40 PM
- no changes were found...
- 181-001.patch 1.7 KB
josh July 17th, 2008 @ 01:36 AM
- Milestone set to “2.x”
- Assigned user set to “josh”
- Tag set to “actionpack”
I think that should be the correct behavior. Can you get me a fix too. If not, I'll try to tackle it as well.
You flagged this item as spam.
David Röthlisberger July 17th, 2008 @ 02:01 AM
I am swamped under at the moment, and the rails internals are still black magic to me, so it'll be at least a month before I get around to trying to fix it.
If you can tackle it go ahead, I appreciate it. :)
In the meantime I have worked around the problem by specifying the input name manually, i.e.
fields_for('post[123][comment][]')
instead of
f.fields_for('comment[]')
josh July 19th, 2008 @ 01:45 AM
The state of form helpers like this feels very hackish.
I think we should analysis some current patterns and refactor it all.
You flagged this item as spam.
Clemens Kofler July 19th, 2008 @ 11:46 AM
Joshua: I've started refactoring the helpers in my Rails fork at github.com/clemens/rails. There's also a topic in the mailing list (http://groups.google.com/group/r...).
FormHelper is definitely on my list, too. There's also relevant topics here and here
You flagged this item as spam.
RSL July 19th, 2008 @ 01:10 PM
There's been some changes to how index is handled as well. http://rails.lighthouseapp.com/p... has test coverage for indexes on the fields_for. Might be good to mix that in too?
josh July 19th, 2008 @ 09:03 PM
- State changed from “new” to “duplicate”
#327 has patch
You flagged this item as spam.
bingbing March 26th, 2011 @ 01:20 AM
gucci watches