This project is archived and is in readonly mode.
Use #table_exists? In initialize_schema_migrations_table
Reported by Ken Collins | February 9th, 2009 @ 08:31 PM | in 2.x
Use table_exists? in #initialize_schema_migrations_table vs hand-rolled tables.detect so that adapter specific implementations can do the leg work of finding out if the schema_info/migration tables really does exist.
Adapters like SQL Server it is common to have a 'dbo.' table name prefix for the user and this causes the migrations to bomb unless we manually specify schema_migrations_table_name to return the correct name.
Comments and changes to this ticket
-
Brennan Dunn February 9th, 2009 @ 08:34 PM
Considering this directly impacts me (SQL Server adapter)... +1
-
-
Ken Collins February 9th, 2009 @ 08:37 PM
It's not a stop the world bug, but it's the second time this week where I have had to patch hand rolled usage of tables.detect or tables.include vs delegating to the adapter. I like consistency :)
-
-
Jonas Schneider February 9th, 2009 @ 08:55 PM
if that isn't being patched, i would at least change detect to any? :)
-
-
CancelProfileIsBroken April 22nd, 2009 @ 10:42 PM
- Assigned user set to “Pratik”
-
Repository May 1st, 2009 @ 02:58 PM
- State changed from “new” to “resolved”
(from [b193f233908823cccd2f1d5fcb4146787ed8c4ed]) Use table_exists? in #initialize_schema_migrations_table [#1923 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Brian
Ken Collins
Pratik
Attachments
Tags
Referenced by
-
1923
Use #table_exists? In initialize_schema_migrations_table
(from [b193f233908823cccd2f1d5fcb4146787ed8c4ed]) Use
tab...