This project is archived and is in readonly mode.
Use #table_exists? In initialize_schema_migrations_table
Use table_exists? in #initialize_schema_migrations_table vs hand-rolled tables.detect so that adapter specific implementations can do the leg work of finding out if the schema_info/migration tables really does exist.
Adapters like SQL Server it is common to have a 'dbo.' table name prefix for the user and this causes the migrations to bomb unless we manually specify schema_migrations_table_name to return the correct name.
-
use_table_exists.diff
1.67 KB
-
Brennan DunnConsidering this directly impacts me (SQL Server adapter)... +1
-
Brian
+1 - directly impacts
-
Ken CollinsIt's not a stop the world bug, but it's the second time this week where I have had to patch hand rolled usage of tables.detect or tables.include vs delegating to the adapter. I like consistency :)
-
nagu
Impacts me too...
-
Jonas Schneider
if that isn't being patched, i would at least change detect to any? :)
-
Scott Jacobsen+1 direct effect
-
CancelProfileIsBroken
- Assigned user set to Pratik
-
Repository
- State changed from new to resolved
(from [b193f233908823cccd2f1d5fcb4146787ed8c4ed]) Use table_exists? in #initialize_schema_migrations_table [#1923 Use #table_exists? In initialize_schema_migrations_table state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...