Transaction block sets model ID to non-existent row

Whoops, here's the code block formatted correctly:

>> client_user = new_client_user( :first_name => nil ) # Will cause validation to fail
=> #<ClientUser id: nil, login: "rene173744", email_address: "far...@bosman.com", first_name: nil, last_name: "Sim", active: true>
>> establishment = new_establishment( :brand => brand )
=> #<Establishment id: nil, brand_id: 4, name: "Pretoria GrandWest" ,active: true>
>> Establishment.transaction{ establishment.save!; client_user.save!  } rescue false
=> false
>> establishment.id
=> 10
>> establishment.new_record?
=> false
>> client_user.id
=> nil
>> establishment.reload
ActiveRecord::RecordNotFound: Couldn't find Establishment with ID=10
...
>> Establishment.count
=> 4

Failing test case patch attached. Problem still unresolved.

verified

Reproducible in Rails 2.3.2 using MySQL.

verified

+1 This is a relatively important bug. The test case fails.

+1 verified.

Ran the test, the test seems to be appropriate. Does fail.

verified in master.
+1 does seem like an important bug.

+1

Verified on master, but seems like it's going to be a fairly tricky fix.

+1 verified on sqlite3 as well.

+1 verified Mysql and sqlite 3 Sounds like some kind of a GC is required when rescuing within a transaction. i traced it up until rollback_active_record_state! on transactions.rb, but it seems that the rollback is being preformed only on the instance that raised the exception and not all instances in the transaction as it should.

+1 verified mysql and sqlite3.

see below for an rspec example which shows the unexpected behaviour


require 'spec_helper'
describe Author do
self.use_transactional_fixtures = false

after(:each) do

end

it "should behave normal when using transactions" do

end end

+1 breaks nested forms with validation.

Isn't it a critical issue? basically it means that transactions containing multiple objects doesn't work.