sqlite missing ddl transactions and savepoints

Fixed.

I hadn't run the tests, but have now. All fixed to take account of the old VACUUM call in add_column which was preventing it from being wrapped in a transaction.

Yeah, you were meant to assign it to me :)

-      def supports_count_distinct? #:nodoc:
-        false
-      end

Why did you remove that?

Because this is in SQLiteAdapter which SQLite2Adapter inherits from:

@@@ruby def supports_count_distinct? #:nodoc: sqlite_version >= '3.2.6' end @@@@

Which made it redundant in SQLite2Adapter.

Oops:

def supports_count_distinct? #:nodoc:
  sqlite_version >= '3.2.6'
end

Ok, I give up :)

Looks good to me, I'll take a proper look tomorrow though.

As for the comments, don't stress, I pretty much only use the emails anyway ;)

This doesn't apply cleanly any more? but yes, this looks good and I'm happy to apply it.

If you can upload a rebased version that is.

Rebased.

Just nudging this ticket - I've rebased it again...

Fixed, and rebased again.

The patch should also modify migration_test.rb#test_migrator_one_up_with_exception_and_rollback for testing that with sqlite adapters supporting ddl transactions.

This is related to #1651. The patch should incorporate tests from the trac patch if relevant.

Thanks. I'll have some time later today (about 8 hours from now) and will take a look and add these tests then.

Done, fixed #1651 as well.

Pulled out the savepoint stuff and rebased (and squashed some whitespace I pulled in when I pasted the tests from #1651).