This project is archived and is in readonly mode.
Unpack gems into vendor exactly once
Reported by Matt Jones | February 27th, 2009 @ 11:31 PM
Some gems apparently are packed oddly, with (for example) all files set to read-only. (Hoe is one - thanks ssoroka!)
This causes problems, as the 2.2 gem unpack code will unpack dependencies more than once.
The attached patch is more careful with dependencies; it will only unpack each gem once. This should fix issues that some users have been having with gems:unpack:dependencies.
Comments and changes to this ticket
-
-
Pratik February 28th, 2009 @ 10:38 AM
- Assigned user set to “Pratik”
-
Pratik February 28th, 2009 @ 03:47 PM
Shouldn't we have tests for this ? Also, I think dependencies() should take an options hash instead of a boolean true/false.
Thanks.
-
Pratik February 28th, 2009 @ 03:59 PM
- Milestone set to “2.x”
Removing 2.3 keyword. Please slap it back once we have a new patch.
-
Matt Jones March 1st, 2009 @ 12:34 AM
Working up a new patch, but I've got a question: A test for this is going to be hard to arrange. By design, gems already in vendor/gems aren't unpacked. So either there's going to be an external dependency, or a whole lot of mocking. Any ideas?
I'm incorporating the options hash; so dependencies(true) => dependencies(:flatten => true).
-
Matt Jones March 1st, 2009 @ 12:59 AM
- Milestone cleared.
I've attached a new patch. It cleans up the logic significantly by moving the decision to unpack into GemDependency#unpack_to, rather than scattered over the rake tasks.
-
Repository March 1st, 2009 @ 11:59 AM
- State changed from “new” to “resolved”
(from [a3ac1e1621506a6519b265ef6ec6abc70f6c8a27]) Display gem dependencies correctly and unpack exactly once [#2097 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Matt Jones
Pratik
Attachments
Referenced by
-
2097
Unpack gems into vendor exactly once
(from [a3ac1e1621506a6519b265ef6ec6abc70f6c8a27]) Display...
-
2195
Fix the gem dependency system in Rails
Finally, I'm interested to know what drove this patch - w...
-
2195
Fix the gem dependency system in Rails
using frozen? instead of directly checking for the existe...
-
2195
Fix the gem dependency system in Rails
using frozen? instead of directly checking for the existe...