This project is archived and is in readonly mode.
Wrong elapsed time accouting for views rendering and db time
Reported by Kristian Myllymäki | March 9th, 2009 @ 01:33 PM | in 3.x
I'm running rails 2.2.2
test_controller.rb
class TestController < ApplicationController def time
ActiveRecord::Base.connection.execute("select sleep(2)")
end end
test/time.rhtml
<% ActiveRecord::Base.connection.execute("select sleep(1)") %> Hello World
This generates:
Completed in 3043ms (View: 1008, DB: 2002)
Seems like the database call when rendering the view was not correctly accounted to db time. This does not happen if I explicitly call the render method.
def time
ActiveRecord::Base.connection.execute("select sleep(2)")
render :action => 'time'
end
Then it seems to account it correct:
Completed in 3168ms (View: 7, DB: 3007)
This could give incorrect information to performance- and log analytics.
Comments and changes to this ticket
-
Kristian Myllymäki March 10th, 2009 @ 09:16 AM
Updating ticket with correct formatting:
test_controller.rb
class TestController < ApplicationController
def time ActiveRecord::Base.connection.execute("select sleep(2)") end
end
test/time.rhtml
<% ActiveRecord::Base.connection.execute("select sleep(1)") %> Hello World
This generates:
Completed in 3043ms (View: 1008, DB: 2002)
Seems like the database call when rendering the view was not correctly accounted to db time. This does not happen if I explicitly call the render method.
def time ActiveRecord::Base.connection.execute("select sleep(2)") render :action => 'time' end
Then it seems to account it correct:
Completed in 3168ms (View: 7, DB: 3007)
This could give incorrect information to performance- and log analysis.
-
Steve St. Martin April 15th, 2010 @ 09:21 PM
- Assigned user set to Ryan Bigg
Not sure I completely understand the issue, can you elaborate on it a bit more, or provide a patch.
Can be marked needs-more-info or invalid
-
Ryan Bigg April 15th, 2010 @ 10:42 PM
- State changed from new to incomplete
Please submit a failing test case and patch.
-
Santiago Pastorino February 2nd, 2011 @ 04:35 PM
- State changed from incomplete to open
- Tag changed from 2.2, 2.2-stable, action_controller, performance to 22, 22-stable, action_controller, performance
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino February 2nd, 2011 @ 04:35 PM
- State changed from open to stale
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>