#2244 script runner should overwrite $0 - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2244 ✓resolved

script runner should overwrite $0

Reported by Kiyoshi | March 16th, 2009 @ 12:15 AM | in 3.x

When loading Ruby code from a file, script/runner should rename $0 (and $PROGRAM_NAME) to that file name.

Comments and changes to this ticket

You flagged this item as spam.
Steve St. Martin April 15th, 2010 @ 09:39 PM
- Assigned user set to “Ryan Bigg”
please submit a patch. mark as incomplete
Ryan Bigg April 15th, 2010 @ 10:37 PM
- State changed from “new” to “incomplete”
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Rohit Arondekar June 19th, 2010 @ 09:17 AM
- State changed from “incomplete” to “open”
I've attached a patch that does what Kiyoshi has asked for.
- rails_runner.diff 835 Bytes
Rohit Arondekar June 19th, 2010 @ 11:34 AM
- Tag changed from “runner, script” to “patch, runner, script”
Ignore previous patch. This one properly sets $0 and $PROGRAM_NAME to the filename.
- rails_runner.diff 841 Bytes
David Trasbo June 20th, 2010 @ 03:12 PM
+1

I tried it with a fresh Rails 3 app and it works.

I think the variables should be set like app/models/person.rb instead of just person.rb (relatively to Rails.root) to be consistent with normal $0 and $PROGRAM_NAME behavior.
If you, for example, run ruby foo/bar/baz.rb the two variables will both be set to foo/bar/baz.rb.
Rohit Arondekar June 20th, 2010 @ 03:21 PM
- Assigned user changed from “Ryan Bigg” to “José Valim”
Thanks David. Actually the first patch behaves like that. It will set $0 and $PROGRAM_NAME to the argument passed to runner, in case the file exists.
Rohit Arondekar June 21st, 2010 @ 02:08 AM
I couldn't find any tests for Rails Runner. Does it need tests? I wouldn't mind having a go at writing some.
José Valim June 21st, 2010 @ 10:08 AM
Hey Rohit, please do add a few tests (at least one for filename and another one for simply passing a string). You can take as base this rake test in Railties:

http://github.com/rails/rails/blob/master/railties/test/application...
Rohit Arondekar June 22nd, 2010 @ 06:01 AM
I just started on this, but another ticket #4249 has opened up which may change a few things. So I think it's best if I wait?
Rohit Arondekar June 22nd, 2010 @ 02:18 PM
Attached patch that resolves the issue and also adds 4 tests for runner.
- rails_runner.diff 2.8 KB
Repository June 22nd, 2010 @ 02:22 PM
(from [9be0b509628388a290b117e6b02df871d97f8c2d]) Added 4 tests for Rails Runner. 2 failing tests for $0 and $PROGRAM_NAME [#2244 state:open]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/9be0b509628388a290b117e6b02df8...
Repository June 22nd, 2010 @ 02:22 PM
- State changed from “open” to “resolved”
(from [40bf76165c392a15cd74321dd7d1cbc96c77bd27]) Rails Runner now sets $0 and $PROGRAM_NAME to name of file being run [#2244 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/40bf76165c392a15cd74321dd7d1cb...