This project is archived and is in readonly mode.
Unabled to flush memoized values for private methods
The attached test demonstrates the problem. The issue is when flushing methods is iterates over "methods" which does not include private methods (only public and protected). The solution might just be to change that code to be:
(methods + private_methods).each do |m| .... end
This would need to happen on both the flushing of the cache as well as the priming of the cache.
-
CancelProfileIsBroken- Tag changed from 2.3.2, flush, memoize, private to 2.3.2, bugmash, flush, memoize, private
-
jeem
- Tag changed from 2.3.2, bugmash, flush, memoize, private to 2.3.2, bugmash, flush, memoize, patch, private
This is basically the change Eric recommended. It makes the test pass.
-
make_pri_pro_unmemoizable.diff
2.23 KB
-
jeem
- Tag changed from 2.3.2, bugmash, flush, memoize, patch, private to 2.3.2, bugmash, flush, memoize, private
-
Pratik- Assigned user set to josh
-
Matt Duncan
+1 Nice - applies cleanly to both 2-3-stable and master with all tests passing.
-
Elad Meidar+1 nice catch.
patch applies cleanly on both 2-3-stable and master with tests passing with flying colors.
-
Rizwan Rezaverified
+1 the patch applies cleanly. All tests pass.
-
josh- State changed from new to open
- Milestone changed from 2.x to 2.3.4
-
Repository
- State changed from open to resolved
(from [e4ceea3795ecc7adcec28a1b9d63782be1401256]) make private_and_public_methods unmemoizable [#2372 Unabled to flush memoized values for private methods state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com
http://github.com/rails/rails/commit/e4ceea3795ecc7adcec28a1b9d6378... -
Repository
(from [cc3183d4bec6855b9b5931759a22dd228dfe7687]) make private_and_public_methods unmemoizable [#2372 Unabled to flush memoized values for private methods state:resolved]
Signed-off-by: Joshua Peek josh@joshpeek.com
http://github.com/rails/rails/commit/cc3183d4bec6855b9b5931759a22dd... -
CancelProfileIsBroken
- Tag changed from 2.3.2, bugmash, flush, memoize, private to 2.3.2, flush, memoize, private