This project is archived and is in readonly mode.
deprecate fails on methods ending with equal sign
it is not possible to deprecate methods that end with "=" using ActiveSupport::Deprecation.
class Foo
attr_accessor bar
deprecate :bar=
end
this throws the following error:
active_support/deprecation.rb:100:in `deprecate': compile error (SyntaxError)
activesupport/lib/active_support/deprecation.rb:99: syntax error, unexpected ',', expecting '='
this is because Foo.foo=(*bar) is not valid ruby
syntax. The fix is to use send instead.
-
fix-deprecate.patch
3.34 KB
-
Levin Alexanderattached is an updated patch that adds
assert_deprecated { @dtc.f = :foo }to the tests -
Levin Alexander
attached is an updated patch that adds
assert_deprecated { @dtc.f = :foo }to the tests-
fix-deprecate.2.patch
3.61 KB
-
-
-
Levin Alexander
- Tag changed from active_support, patch to 2.x, 3.0, active_support, patch, small
-
CancelProfileIsBroken
- Tag changed from 2.x, 3.0, active_support, patch, small to 2.x, 3.0, active_support, bugmash, patch, small
-
Michael Siebert
+1
for levin's patch for 2-3-stable, applies clean and works. we're currently using this patch in production for our own app, so i consider it production-ready
-
Michael Siebert
+1 for the 2nd patch (for master), too, verified that it works
-
Matt Duncan
+1 for both patches (2-3-stable and master), verified that both are passing tests and working as expected.
-
Dan Pickettverified
-1 however - a symbol cannot end in equal sign - the deprecate call should really be proper syntax -
deprecate "bar="
-
Dan Pickett
sorry - Josevalim corrected me symbols with = at the end are valid > 1.8.6
-
Levin Alexander
seems they are also valid in ruby 1.8.6:
system:~$ ruby --version ruby 1.8.6 (2007-06-07 patchlevel 36) [x86_64-linux] system:~$ ruby -e "p :foo=" :foo= -
Nick Quaranto+1, both patches look fine to me and activesupport's tests are passing.
-
Kieran P+1 for both 2-3-stable and master patches applying cleanly.
-
Rizwan Reza- Tag changed from 2.x, 3.0, active_support, bugmash, patch, small to 2.x, 3.0, active_support, bugmash, patch, small, verified
verified
+1 The patches work fine.
-
José Valim- State changed from new to resolved
- Tag changed from 2.x, 3.0, active_support, bugmash, patch, small, verified to 2.x, 3.0, active_support, patch, small, verified
-
Repository
(from [d811864e880580549bc1ab73a1ab0be886598e6e]) Fix deprecating =-methods by using send [#2431 deprecate fails on methods ending with equal sign status:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/d811864e880580549bc1ab73a1ab0b... -
Repository
(from [4c96030d05b877919dfe2613290826beee464240]) Fix deprecating =-methods by using send [#2431 deprecate fails on methods ending with equal sign status:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/4c96030d05b877919dfe2613290826...