This project is archived and is in readonly mode.

:uniq option doesn't work with has_many :through and eager loading

#2447



class LineItem
  belongs_to :event
end  

class Order
  has_many :line_items
  has_many :events, :through => :line_items, :uniq => true
end

Order.first(:joins => :line_items).events # => expected result
Order.first(:joins => :line_items).event_ids # => contains duplicate IDs
Order.first(:include => :line_items).events # => contains duplicates
Order.first(:include => :line_items).event_ids # => contains duplicate IDs

Reported by DerGuteMoritz · April 7th, 2009 @ 08:41 PM

Activity

Jeremy Kemper
- Milestone changed from 2.x to 3.x
[bulk edit]

May 4th, 2010 @ 06:48 PM
Jon Leighton
- Assigned user set to Aaron Patterson
- Tag changed from activerecord, eager_loading, has_many_through, uniq to activerecord, eager_loading, has_many_through, patch, uniq
- Importance changed from to
Here is a patch which fixes this, with tests.
- 2447_uniq_through_associations_with_eager_loading.diff 3.87 KB
December 16th, 2010 @ 12:51 AM
Repository
- State changed from new to resolved
(from [09ddca67acbb88e2fdd7300670839cbf647b2694]) Fix problem with duplicated records when a :uniq :through association is preloaded [#2447 :uniq option doesn't work with has_many :through and eager loading state:resolved] https://github.com/rails/rails/commit/09ddca67acbb88e2fdd7300670839...

December 16th, 2010 @ 01:49 AM
Sean Hussey
I realize this is long-closed, by is there any reason why it wasn't backported to 2.3.x? It was originally reported on the 2.3 branch, but this fix wasn't included in the 2.3.11 release (almost 2 months after this patch was applied).

I've got it handled in my apps now, but it seems like this was lost in the shuffle (reported 4/2009, recategorized 5/2010, patched 12/2010).

April 18th, 2011 @ 08:37 PM
Jon Leighton
Sean, the 2.3 branch is not having any further releases. If you would like to backport the patch to the 3-0-stable branch then feel free and I will apply it.

April 18th, 2011 @ 08:58 PM