This project is archived and is in readonly mode.
Rendering "~" caches (2027) still broken
2.3.2 is still preferring temp files over exact matches. I saw your added tests so I ran them to see what I was missing and they fail.
I attached the output of
vendor/rails/actionpack $ rake test
-
broken.txt
4.81 KB
-
Sean Bryant- Tag changed from action_view, bug to 2.3.2.1, action_view, bug, render, rendering
I can confirm this as being a problem. It will want to use emacs backup files.
-
ransom-briggs (at uiowa)
This is related to how bzr handles revert backups and cleaning up temporary files. The test suite actually worked until I did a clean-tree --detritus which removed the test files. Although it still does not work with bzr backups
bzr backups are in the form original_file.html.erb.~1~ which breaks the extension detection code. The extension is detected as erb so valid_extension? does not eliminate this file. I've attached a fix - basically it verifies that when the extensions split is done that it doesn't fall back to the second part if the third part is invalid.
A breaking test is achieved by doing the following...
cp ./test/fixtures/test/malformed/malformed.en.html.erb~ ./test/fixtures/test/malformed/malformed.en.html.erb.~1~
-
-
thedarkone
Guys, have you tried using the 2-3-stable branch instead of v2.3.2.1 tag?
-
ransom-briggs (at uiowa)
- Tag changed from 2.3.2.1, action_view, bug, render, rendering to 2.3.2, 2.3.2.1, action_view, bug, render, rendering
This is using the release of 2.3.2 as well - adding as a tag
-
josh- Assigned user changed from josh to Yehuda Katz (wycats)
Lets make sure this problem doesn't exist on master.
-
thedarkone
I think this is fixed in 2-3-stable and I'm pretty sure the current master's
Pathimplementation is immune to this bug. -
ransom-briggs (at uiowa)
This is broken in the gem version of 2.3.2 but is fixed in the current master on github (test passed and I glanced at the current implementation and it looks good - ie: it grabs the last extension explicitly using the regex rather than the second to last in the case when that is in the gem)
-
2513.txt
32.2 KB
-
-
ransom-briggs (at uiowa)
it also appears to be fixed in origin/2-3-stable
-
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2.3.2, 2.3.2.1, action_view, bug, render, rendering to 232, 2321, action_view, bug, render, rendering
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
gfh
Good Puma shoes sale information for Puma shoes fans: Yesterday, German sportswear maker Cheap Running Shoes purchased effectively lot of money Brands. The transaction entails the Cobra brand, too as linked inventory, intellectual house and endorsement contracts. It also helps make puma speed cat Shoes . They provide you with the utmost game and support all through the feet.You can happen around several types of basketball sneakers such as high-top,low-top and mid-top.The Puma shoes online and boots give you best ankle support will support want you to obtain steadiness.
As we konw,Trail Puma Drift Cat Shoes black, Trail Puma future cat ShoesWhite Black? 50 many years backshore are actually released within a great accomplishment. Trail Running Shoes speed cat shoes?go in add-on to King Pele into planet tournament finals, bottom tennis discs matchrs within pasture inhabit an vital area in hold out in Wimbledon Dun; Its working firms have premier manufacturers and major marketplace positions in distilled spirits, residence and security, and golf products. The reply go all through the Cheap puma shoes on sale-here you are able to happen around several distcoun.puma shoes on sale .