This project is archived and is in readonly mode.
Sent_on should default to now
Reported by Joel Chippindale | May 5th, 2009 @ 09:38 AM
Sent_on should default to now in ActionMailer.
Currently it has no default. If you don't set sent_on then your mail will be sent without a date header. This has unpredictable results because although most mail server will insert a date header (defaulting to now) when the date header is missing not all will do so.
Defaulting to Time.now follows the principle of least surprise.
Comments and changes to this ticket
-
Cheah Chu Yeow May 12th, 2009 @ 05:53 PM
Patch checks out, all tests pass. +1
I was initially concerned about the removal of the test for Time.local(2004, 12, 12) but I can see that's already being tested in the other testcases.
-
Grant Hutchins June 10th, 2009 @ 10:35 PM
Perhaps using nil for sent_on should give the original behavior.
-
Joel Chippindale June 11th, 2009 @ 09:48 AM
- no changes were found...
-
Joel Chippindale June 11th, 2009 @ 09:48 AM
This is the behaviour of this patch.
I've attached a new version of the patch with a test to showing this.
-
CancelProfileIsBroken August 7th, 2009 @ 02:02 PM
- Tag changed from “actionmailer, date, patch” to “actionmailer, bugmash, date, patch”
-
Matt Duncan August 8th, 2009 @ 02:44 AM
+1 I updated the patch to apply cleanly to the latest 2-3-stable, looks good and all tests pass.
I've attached a patch.
-
Repository August 8th, 2009 @ 03:11 AM
- State changed from “new” to “committed”
(from [5fdc33c1a37b4c321135753ed546e8afc2dbaf3e]) Default sent_on time to now in ActionMailer
Signed-off-by: Michael Koziarski michael@koziarski.com
[#2607 state:committed] http://github.com/rails/rails/commit/5fdc33c1a37b4c321135753ed546e8... -
Repository August 8th, 2009 @ 03:11 AM
(from [f73d34c131c1e371c76c5a146aac2c2bffbf96e5]) Default sent_on time to now in ActionMailer
Signed-off-by: Michael Koziarski michael@koziarski.com
[#2607 state:committed] http://github.com/rails/rails/commit/f73d34c131c1e371c76c5a146aac2c... -
CancelProfileIsBroken August 8th, 2009 @ 11:05 PM
- Tag changed from “actionmailer, bugmash, date, patch” to “actionmailer, date, patch”
- Milestone cleared.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
CancelProfileIsBroken
Attachments
Tags
Referenced by
-
2607
Sent_on should default to now
Signed-off-by: Michael Koziarski
michael@koziarski.com
[#...
-
2607
Sent_on should default to now
Signed-off-by: Michael Koziarski michael@koziarski.com
[#...