This project is archived and is in readonly mode.
Sent_on should default to now
Sent_on should default to now in ActionMailer.
Currently it has no default. If you don't set sent_on then your mail will be sent without a date header. This has unpredictable results because although most mail server will insert a date header (defaulting to now) when the date header is missing not all will do so.
Defaulting to Time.now follows the principle of least surprise.
-
Cheah Chu YeowPatch checks out, all tests pass. +1
I was initially concerned about the removal of the test for Time.local(2004, 12, 12) but I can see that's already being tested in the other testcases.
-
Grant HutchinsPerhaps using nil for sent_on should give the original behavior.
-
-
Joel Chippindale
This is the behaviour of this patch.
I've attached a new version of the patch with a test to showing this.
-
CancelProfileIsBroken
- Tag changed from actionmailer, date, patch to actionmailer, bugmash, date, patch
-
Matt Duncan
+1 I updated the patch to apply cleanly to the latest 2-3-stable, looks good and all tests pass.
I've attached a patch.
-
2607.diff
1.85 KB
-
-
Repository
- State changed from new to committed
(from [5fdc33c1a37b4c321135753ed546e8afc2dbaf3e]) Default sent_on time to now in ActionMailer
Signed-off-by: Michael Koziarski michael@koziarski.com
[#2607 Sent_on should default to now state:committed] http://github.com/rails/rails/commit/5fdc33c1a37b4c321135753ed546e8... -
Repository
(from [f73d34c131c1e371c76c5a146aac2c2bffbf96e5]) Default sent_on time to now in ActionMailer
Signed-off-by: Michael Koziarski michael@koziarski.com
[#2607 Sent_on should default to now state:committed] http://github.com/rails/rails/commit/f73d34c131c1e371c76c5a146aac2c... -
CancelProfileIsBroken
- Tag changed from actionmailer, bugmash, date, patch to actionmailer, date, patch
- Milestone cleared.