Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Joel Chippindale's latest activity

Monday, February 07 2011
6022 Content negotiation fails for some */* headers (regression) was updated in Ruby on Rails
  • Joel Chippindale
    Joel Chippindale commented at 12:59 PM

    Keen Ejima,

    The bug you mentioned with

    HTTP_ACCEPT: */*;q=0.01
    

    Is covered by #5833 which includes a patch to fix.

    J.

5833 Bug in Mime::Type#parse for single media range with accept params was updated in Ruby on Rails
  • Joel Chippindale
    Joel Chippindale commented at 12:57 PM

    This is still an issue with master, here is a new version of the patch which applies cleanly to current master.

  • Joel Chippindale
    Joel Chippindale commented at 12:38 PM

    Piotr,

    The patch for master does not use /;/, rather they both use ';'

    If you look in the patch for master and for 2.3 the line is

    [Mime::Type.lookup(accept_he...
5799 Memoizable#prime_cache is broken for private and protected methods was updated in Ruby on Rails
  • Joel Chippindale
    • State changed from stale to open
    by Joel Chippindale at 12:26 PM

    [state:open] This patch still applies cleanly, and without it the version of Memoizable on rails/master still fails to memoize private and protected methods cor...

Monday, October 18 2010
5833 Bug in Mime::Type#parse for single media range with accept params was updated in Ruby on Rails
  • Joel Chippindale
    Joel Chippindale commented at 12:08 PM

    And patch for 2-3-stable

  • Joel Chippindale
    • Tag changed from http accepts, actionpack to http accepts, actionpack, patch
    by Joel Chippindale at 12:07 PM

    Attached patch for master

  • Joel Chippindale
    Joel Chippindale created the ticket at 11:54 AM

    Mime::Type#parse doesn't split out the accept params from the media range when there is a single media range.

    I.e. it incorrectly parses the valid HTTP_ACCEPTS ...

Wednesday, October 13 2010
5799 Memoizable#prime_cache is broken for private and protected methods was updated in Ruby on Rails
  • Joel Chippindale
    • Tag changed from activesupport, memoizable to activesupport, memoizable, patch
    by Joel Chippindale at 11:23 AM

    Patch to fix the bug (with additional tests) attached

  • Joel Chippindale
    Joel Chippindale created the ticket at 11:02 AM

    Memoizable#prime_cache ignores private and protected methods.

    This means that memoization of private and protected methods does not work on objects that are fro...