Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Memoizable#prime_cache is broken for private and protected methods

#5799

Memoizable#prime_cache ignores private and protected methods.

This means that memoization of private and protected methods does not work on objects that are frozen.

Reported by Joel Chippindale · October 13th, 2010 @ 11:02 AM

State: open
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Joel Chippindale
    Joel Chippindale
    • Tag changed from activesupport, memoizable to activesupport, memoizable, patch

    Patch to fix the bug (with additional tests) attached

    October 13th, 2010 @ 11:23 AM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:30 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:30 PM

  4. Joel Chippindale
    Joel Chippindale
    • State changed from stale to open

    [state:open] This patch still applies cleanly, and without it the version of Memoizable on rails/master still fails to memoize private and protected methods correctly.

    February 7th, 2011 @ 12:26 PM