This project is archived and is in readonly mode.

#5799 open
Joel Chippindale

Memoizable#prime_cache is broken for private and protected methods

Reported by Joel Chippindale | October 13th, 2010 @ 11:02 AM

Memoizable#prime_cache ignores private and protected methods.

This means that memoization of private and protected methods does not work on objects that are frozen.

Comments and changes to this ticket

  • Joel Chippindale

    Joel Chippindale October 13th, 2010 @ 11:23 AM

    • Tag changed from activesupport, memoizable to activesupport, memoizable, patch

    Patch to fix the bug (with additional tests) attached

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:30 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:30 PM

    • State changed from “open” to “stale”
  • Joel Chippindale

    Joel Chippindale February 7th, 2011 @ 12:26 PM

    • State changed from “stale” to “open”

    [state:open] This patch still applies cleanly, and without it the version of Memoizable on rails/master still fails to memoize private and protected methods correctly.

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages