This project is archived and is in readonly mode.

#2647 ✓stale
Deleted User

ActionController::TestRequest and query_string

Reported by Deleted User | May 14th, 2009 @ 01:35 PM | in 3.x

In Rails pre 2.3.x the following could be used in tests:

user_request = ActionController::TestRequest.new(nil,{:application => 'Test'}, nil)
user_request.request_uri = "http://test.com/app/Test/"
user_request.query_string

In the new Rack implementation this should be rewritten a bit

test_request = ActionController::TestRequest.new
test_request.request_uri = "http://test.com/app/test/"
test_request.query_string

But this fails with

NoMethodError: You have a nil object when you didn't expect it!
You might have expected an instance of Array.
The error occurred while evaluating nil.split

This is due to @env['REQUEST_URI'] not being set in query_string in ActionController::Request when using TestRequest.

However the following works:

test_request = ActionController::TestRequest.new
test_request.set_REQUEST_URI('http://test.com/app/Test/')
test_request.query_string

I expected request_uri=() to actually set request_uri but it does not. Using set_REQUEST_URI seems a bit clumsy.

Comments and changes to this ticket

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:50 PM

    • State changed from “new” to “open”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:51 PM

    • State changed from “open” to “stale”
  • bingbing

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages