This project is archived and is in readonly mode.
Model updates not working correctly when used in a migration and a table with inheritance
-
CancelProfileIsBroken
- State changed from new to incomplete
As a practical matter, if you want to get some attention to this, the first step is to submit at least a failing test patch to the version of Rails you're using. See http://guides.rubyonrails.org/contributing_to_rails.html
-
Valentin Mihov
Should it be just a diff or I can branch the code in github and write the test there?
-
CancelProfileIsBroken
Just attach a diff with a failing test here. The contributing guide will walk you through constructing the diff if you need help.
-
Valentin Mihov
A quite simple unit test for the described issue. It shows the issue in a much more simple way than I described ;-) The unit test is written on the origin/2-2-stable branch.
Should I try that unit test in the rails-edge also?
-
CancelProfileIsBroken
- State changed from incomplete to new
Thanks!
Ideally, we'd want to know whether the issue persists on 2-3-stable and on master.
Bonus points if you can come up with a patch to fix it :)
-
Valentin Mihov
Thanks for the help!
The issue persists on the master branch and on 2-3-stable. Should I submit separate patches with the test for these?
Any naming conventions if I do that? -
CancelProfileIsBroken
I suspect that patch will apply cleanly across all 3 branches - don't think there's been much change in that area of code lately. If not, you could just put the version in the patch title, there's no formal naming convention.
-
Valentin Mihov
Yes. It applies fluently.
I will look around the code later and try to figure out a fix for the problem.
-
Rohit Arondekar
- State changed from new to stale
- Importance changed from to
Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.
