local error page does not show session

I've created a patch for 2-3-stable and tested on my 2.3.4 app. I rebased to master as well. There are no tests because testing the output of this template seems too granular, but I'm open to suggestions on a good way to test it if necessary. My instinct is that it should just be fixed.

This should be fixed in ExceptionNotifiable (http://github.com/rails/exception_notification), for 3.0 and 2.3 branches, actually via a couple other refactors. Please re-tag and add the appropriate details, if you find that not to be the case.

Or add a ticket in the Rails plugin project: https://rails.lighthouseapp.com/projects/8995

[bulk edit]

I was unable to reproduce this with edge Rails:

$ script/rails g controller fails index
      create  app/controllers/fails_controller.rb
       route  get "fails/index"
      invoke  erb
      create    app/views/fails
      create    app/views/fails/index.html.erb
      invoke  test_unit
      create    test/functional/fails_controller_test.rb
      invoke  helper
      create    app/helpers/fails_helper.rb
      invoke    test_unit
      create      test/unit/helpers/fails_helper_test.rb

routes.rb:

Ticket2727::Application.routes.draw do
  resources :fails
end

app/controllers/fails_controller.rb:

class FailsController < ApplicationController
  def index
    session[:foo] = 'bar'
    raise 'fail!'
  end
end

The error page on http://localhost:3000/fails shows this session dump:

foo: "bar"
session_id: "814bfd9248f48b0c965552e06d63b81b"

However, I was I able to reproduce this using the 2-3-stable branch:

$ script/generate controller fails index
      exists  app/controllers/
      exists  app/helpers/
      create  app/views/fails
      exists  test/functional/
      create  test/unit/helpers/
      create  app/controllers/fails_controller.rb
      create  test/functional/fails_controller_test.rb
      create  app/helpers/fails_helper.rb
      create  test/unit/helpers/fails_helper_test.rb
      create  app/views/fails/index.html.erb

routes.rb:

ActionController::Routing::Routes.draw do |map|
  map.resources :fails
end

app/controllers/fails_controller.rb:

class FailsController < ApplicationController
  def index
    session[:foo] = 'bar'
    raise 'fail!'
  end
end

The error page shows --- as session dump, as described.

Please provide a patch (https://rails.lighthouseapp.com/projects/8994/sending-patches) with a fix and/or a failing test.

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.