Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

UrlRewriter should call #to_param on the value given in :anchor

#2746

UrlWriter#url_for method calls #to_param on the value given via the :anchor option:

url_for(:host => 'www.example.com', :controller => 'comments', :anchor => Comment.first)
# => "http://www.example.com/comments#1"

but UrlRewriter#rewrite_url does not:

comments_url(:anchor => Comment.first)
# => "http://www.example.com/comments##<Comment:0x37cc100>"

This patch makes #rewrite_url follow suit.

Reported by Jeffrey Hardy · June 2nd, 2009 @ 08:07 PM

State: committed
Milestone: 2.x
Assigned to: nobody
Importance: none

Activity

  1. Jeffrey Hardy
    Jeffrey Hardy

    Wups, let's not modify the options hash

    June 2nd, 2009 @ 08:11 PM

  2. Craig Davey
    Craig Davey

    +1

    June 4th, 2009 @ 09:35 PM

  3. Repository
    Repository
    • State changed from new to committed

    (from [05b529ca57f75ce64540b9d34597e0c3bfe1fca7]) UrlRewriter#rewrite_url should call #to_param on the value given in :anchor option, just as #url_for does

    [#2746 UrlRewriter should call #to_param on the value given in :anchor state:committed]

    Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
    http://github.com/rails/rails/commit/05b529ca57f75ce64540b9d34597e0...

    August 26th, 2009 @ 10:55 PM

  4. Repository
    Repository

    (from [4240890b28ea7d797d812202315ceeda55bac71e]) UrlRewriter#rewrite_url should call #to_param on the value given in :anchor option, just as #url_for does

    [#2746 UrlRewriter should call #to_param on the value given in :anchor state:committed]

    Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
    http://github.com/rails/rails/commit/4240890b28ea7d797d812202315cee...

    August 26th, 2009 @ 10:55 PM