This project is archived and is in readonly mode.
Aggregation writer doesn't behave nicely when converter returns nil
-
Michael Koziarski
- Milestone changed from 2.x to 2.3.4
-
Rizwan Reza
- Tag changed from activerecord, aggregations, patch, testcase to activerecord, aggregations, bugmash, patch, testcase
-
Santiago Pastorino
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
-
jfelchner
This is most definitely something that I would like to see fixed in 3.1. I am currently having the same problem where the converter should (correctly) return nil but the mapping methods are being called on it.
I understand resources are limited but 2 years seems like an excessively long amount of time to get a small change like this merged in.
If this particular patch is now out of date for the 3.x branch, let me know and I'll convert it over.
-
Chris Hapgood
jfelchner,
At a minimum, this ticket is going to need to be moved to the new system on GitHub. Care to take a stab? -
jfelchner
I'm on it. Forgot you guys switched over. I also took a look and the patch is no longer valid. I'll submit a new pull request with a link back to this page.
Thanks for the quick reply Chris.
