This project is archived and is in readonly mode.
Typo in Rails Plugin Manager is stopping git repos behind SSH working
I was having problems installing git based plugins over SSH, e.g.
ssh://[user@]host.xz/path/to/repo.git/
Bit of digging and I spotted a typo in railties/lib/commands/plugin.rb on line 166. @url should be @uri!
Tekin
-
fixes_type_in_rails_plugin_manager.diff
791 Bytes
-
Cheah Chu YeowThere're no existing tests for this but this is an obvious fix. Good catch :)
-
TekinYou would have thought so. It still took me a good half am hour of staring at that line before I spotted the typo in disguise!!
-
-
Tekin
I've just created another ticket:http://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/278-patch-for-plugin-install-to-support-scp-syntax-git-repo-urls with a small patch, this time to add support for scp syntax urls, ala private repos on github.
The lack of tests here is problematic as there are lots of opportunities to improve this code. I'm going to find the time to do something about this at some point in the next few weeks..
-