This project is archived and is in readonly mode.

#2774 ✓committed
Paul Campbell

ActiveRecord tests with the same name

Reported by Paul Campbell | June 7th, 2009 @ 09:59 AM | in 2.x

Hey,

I was mucking about in activerecord/test/cases/finder_test.rb ... about to write a new test, but I came across a bunch of tests with the same name / similar functionality.

For example, lines 158 - 185 have a bunch of finder tests beginning with "test_find_all_with_limit" but this same test is repeated on line 945 and the same functionality tested twice.

It's trivial, but should these repeated tests be removed? I've created the tiny patch here.

Paul

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Referenced by

Pages