This project is archived and is in readonly mode.

#2780 ✓stale
Esben Mose Hansen

Support for infinity from database in validates_numericality_of

Reported by Esben Mose Hansen | June 8th, 2009 @ 08:49 AM | in 3.x

After this patch was accepted

https://rails.lighthouseapp.com/projects/8994/tickets/354-allow-inf...

infinity was partly supported by validates_numericality_of. However, if the infinity (or nan for that matter) stems from the database, the validation would fail. That leads to the rather interesting cases where the model is successfully saved, but a reloading and saving again fails because of validates_numericality_of. I have create a patch that solves the issue. (attached).

Note that support for infinity in the database is broken, at least for postgresql; I will create an issue an attach a patch for this later.

Comments and changes to this ticket

  • Pratik

    Pratik August 9th, 2009 @ 10:02 PM

    • State changed from “new” to “incomplete”

    Hey Esben,

    The patch is missing tests.

    Thanks!

  • Pratik

    Pratik August 9th, 2009 @ 10:02 PM

    • Assigned user set to “Joshua Peek”
  • Joshua Peek

    Joshua Peek August 19th, 2009 @ 03:56 PM

    • Assigned user cleared.
  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Dan Pickett

    Dan Pickett May 9th, 2010 @ 07:28 PM

    • Tag changed from infinity, nan, patch to bugmash, infinity, nan, patch
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “incomplete” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Pages