This project is archived and is in readonly mode.

#2781 ✓stale
Esben Mose Hansen

Postgres adapter does not handle infinity and nan correct

Reported by Esben Mose Hansen | June 8th, 2009 @ 08:55 AM | in 3.x

If a model attempts to save infinity/-infinity/nan to a postgres database, an error about incorrectly quoting results. This is because the value is generate simply by thedouble.to_s, which returns e.g. "Infinity", while postgresql expects "'Infinity'". The attached monkey patch fixes this; it's only a few lines in the postgresql adapter.

Comments and changes to this ticket

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Dan Pickett

    Dan Pickett May 9th, 2010 @ 07:28 PM

    • Tag changed from infinity, nan, patch to bugmash, infinity, nan, patch
  • Jared Pace

    Jared Pace May 14th, 2010 @ 03:48 PM

    We were looking to verify this patch, but are a little confused as to why it is done as a monkey patch instead of a direct change to postgresql_adapter.rb? Why is the indirection of a monkey patch necessary?

  • Diego Algorta

    Diego Algorta May 16th, 2010 @ 01:10 AM

    I've attached a patch

    Here's a proper patch version of Esben's monkey patch (which I had to adapt to be merged into rails master), with included tests.

  • Diego Algorta

    Diego Algorta May 16th, 2010 @ 06:12 PM

    • Assigned user set to “Pratik”

    Would love some feedback on this one.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:38 PM

    • State changed from “new” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:38 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>