This project is archived and is in readonly mode.
Postgres adapter does not handle infinity and nan correct
If a model attempts to save infinity/-infinity/nan to a postgres database, an error about incorrectly quoting results. This is because the value is generate simply by thedouble.to_s, which returns e.g. "Infinity", while postgresql expects "'Infinity'". The attached monkey patch fixes this; it's only a few lines in the postgresql adapter.
-
fix_infinity_in_postgres_adaptor.rb
990 Bytes
-
-
Dan Pickett- Tag changed from infinity, nan, patch to bugmash, infinity, nan, patch
-
Jared PaceWe were looking to verify this patch, but are a little confused as to why it is done as a monkey patch instead of a direct change to postgresql_adapter.rb? Why is the indirection of a monkey patch necessary?
-
Diego AlgortaI've attached a patch
Here's a proper patch version of Esben's monkey patch (which I had to adapt to be merged into rails master), with included tests.
-
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale