This project is archived and is in readonly mode.

#2829 ✓stale
George Montana Harkin

<< a has_many association starts no-op transaction for .new ActiveRecords

Reported by George Montana Harkin | June 24th, 2009 @ 12:21 AM | in 3.x

When building up an object to be saved later in a large transaction, I am adding Models to a has_many relation for another:

Timsheet has many TimesheetRevisions

  timesheet = do |t"
    t.pay_period_id = 12
    t.user_id = user_id

  timesheet_revision = do |tr|
    tr.timehsheet_status_id = timesheet_status_id


Checking the log, right around the << I receive a BEGIN followed by a COMMIT.

It looks to be an issue with << always starting a transaction even if the model has not been saved yet. See line 115 of rails/activerecord/lib/active_record/associations/association_collection.rb

Comments and changes to this ticket

  • George Montana Harkin

    George Montana Harkin July 8th, 2009 @ 08:17 PM

    I've created a simple patch for this issue. It isn't very ruby so you'll probably want to clean it up.

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Dan Pickett

    Dan Pickett May 9th, 2010 @ 07:07 PM

    • Tag changed from has_many to bugmash, has_many

    Can a bugmasher verify this as errant behavior in master with a failing test?

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “new” to “open”
    • Importance changed from “” to “”

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:39 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket