This project is archived and is in readonly mode.
id for radio_button behavior
-
José Valim
Here is a pastie, since Lighthouse and S3 are not friends yet.
-
Nobuhiro IMAI
- Tag changed from 2.3.3, action_view, form_helper to 2.3.3, action_view, form_helper, patch
Hello,
this patch works fine for me, thanks!
-
José Valim
- Tag changed from 2.3.3, action_view, form_helper, patch to 2.3.3, action_view, bugmash, form_helper, patch
-
Rizwan Reza
verified
+1 This patch works in master and 2-3-stable branches. Both of those branches are encountering the same problem unless it's intentional.
-
Rizwan Reza
The tests pass too.
-
Matt Duncan
verified
+1 works and all tests pass, based on the commit where it was added (http://github.com/rails/rails/commit/a14df8c9b26b489f1db8fba64c72da...) this behavior appears to be unintentional.
-
Josh Nichols
Verified the patch applies to 2-3-stable, and returns the previous behavior.
I'm kinda leaning towards -1, because I think the 2.3.3 behavior seems more correct to me. Most of the form helpers have ids like model_attribute, and 2.3.3 makes this consistent for radio buttons as well. I can't really think of a reason you'd want the id to have the current selectedness of a radio button.
-
Jeremy Kemper
- Tag changed from 2.3.3, action_view, bugmash, form_helper, patch to 2.3.3, action_view, form_helper, patch
- State changed from new to committed
- Milestone changed from 2.x to 2.3.4
-
Repository
(from [e972acc0d7b63e5ce15bed69f41214fe741a7c9c]) Allow radio buttons to work with booleans.
[#2937 id for radio_button behavior state:committed]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/e972acc0d7b63e5ce15bed69f41214...
