Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Rails 2.3.2 changes ActionController "expires_in" API needlessly

#2940

Pre-2.3.2 ActionController::Base.expires_in example:

expires_in 10.minutes, :private => false

Rails 2.3.2 version:

expires_in 10.minutes, :public => true

":private" option is ignored. This breaks cache headers for upgraded apps. There is no deprecation warning either.

You can read all about my outrage over here: http://geekblog.vodpod.com/?p=224

Reported by scott persinger · July 22nd, 2009 @ 08:11 PM

State: stale
Milestone: 3.x
Assigned to: nobody
Importance: none

Activity

  1. Susan Potter
    Susan Potter

    I committed a patch and test for the case here on my GitHub fork mbbx6spp/rails with commits:
    * 316df387 Patch for #2940 * c58215a1 Test for #2940

    Also see attached file that includes both commits.

    July 23rd, 2009 @ 02:02 AM

  2. Susan Potter
    Susan Potter

    Sorry formatting didn't quite work out. Hopefully it makes sense.

    July 23rd, 2009 @ 02:02 AM

  3. Susan Potter
    Susan Potter
    • Title changed from Rails 2.3.2 changes ActionController "expires_in" API needlessly to [PATCH] Rails 2.3.2 changes ActionController "expires_in" API needlessly

    July 23rd, 2009 @ 02:03 AM

  4. Susan Potter
    Susan Potter
    • Tag changed from action_controller, caching to action_controller, caching, patch

    July 23rd, 2009 @ 02:24 AM

  5. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.x to 3.x

    May 4th, 2010 @ 06:48 PM

  6. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to stale
    • Importance changed from to

    Marking ticket as stale. If this is still an issue please leave a comment with suggested changes, creating a patch with tests, rebasing an existing patch or just confirming the issue on a latest release or master/branches.

    October 9th, 2010 @ 03:28 AM