This project is archived and is in readonly mode.
drop_table to support temporary option like create_table
Part of an application I am working on creates and drops
temporary tables for processing data.
I have run in to a few problems where creating and dropping tables
breaks testing with transaction fixtures because calling CREATE
TABLE or DROP TABLE causes an implicit COMMIT.
Any action called using active record after a drop_table in a
test causes the following error:
Mysql::Error: SAVEPOINT active_record_1 does not exist:
ROLLBACK TO SAVEPOINT active_record_1 (ActiveRecord::StatementInvalid)
Using temporary tables does not have this behavior, create_table already has the :temporary options available, I have proposed a patch to drop_table to mimic the :temporary option.
Thanks
--Rob
-
drop_table_temporary.diff
528 Bytes
-
Rob Aldredlooks like lighthouse doesn't like my file...
http://gist.github.com/153070 -
Michael Koziarski- Tag changed from activerecord, sql, testing to activerecord, bugmash, sql, testing
-
diraThe patch should be adapter specific - Postgres does not support DROP TEMPORARY TABLE.
So each adapter should expose supports_drop_temporary?, and the drop_method method should take that into account.
-
Dan Pickettverified that this patch applies cleanly to master
-1 on the implementation and feature, though - this sounds like it belongs in an adapter specific plugin or gem
If not, it'd be great to have test coverage for the supported adapters and some type of boolean method like dira suggested or some "not supported" messaging for postgres
-
Rizwan Reza-1 on this from me too. I think this should be adapter specific, IMHO.
-
Elad Meidar-1 here too, classic adapter.
-
CancelProfileIsBroken- Tag changed from activerecord, bugmash, sql, testing to activerecord, sql, testing
- State changed from new to wontfix
Seems a consensus here.
-
Rob Aldred
- Tag changed from activerecord, sql, testing to activerecord, sql, testing
Thanks for your comments, if i get some time, ill patch the mysql adapter and write some tests,
seems there's not much of a call for this so no rush.