Add magic encoding comment to generated files

Here's a simplified model and migration. Making the problem easily reproducible:

class Widget < ActiveRecord::Base
   belongs_to :window







   named_scope :enabled, :conditions => { :enabled => true }
   named_scope :desktop,

           :joins => :window,
           :conditions => { "windows.name" => "desktop" }

end

Migration to use for testing:

     create_table :widgets do |t|

   t.belongs_to :window

   t.string :name
   t.boolean :enabled
 end

 create_table :windows do |t|
   t.string :name
 end</code>

Tested on edge rails (3.0pre), 2.3.3, 2.3.2, 2.3.1, all fail. Works on 2.3.0 and earlier versions.

What is even stranger is that with this minor modification it works on 2.3.3 also:

class Widget < ActiveRecord::Base
   belongs_to :window

   named_scope :enabled, :conditions => { :enabled => true }
   named_scope :desktop,
               :joins => :window,
               :conditions => [ "windows.name = ?", "desktop" ]
end

I haven't been able to figure out what changed between 2.3.0 and 2.3.1 to introduce the bug. Git diff didn't give any good clues, nor did the log entries. Really strange problem.

Verified this generates invalid SQL on 2-3-stable

Besides working with conditions Array, it also works with:

  class Widget < ActiveRecord::Base
    belongs_to :window

    named_scope :enabled, :conditions => { :enabled => true }
    named_scope :desktop,
                :joins => :window,
                :conditions => { :windows => { :name => "desktop" } }
  end

Ok, this is really weird. I think it is related directly to the model name (or only the first letter). I was trying to create a failing test patch, but, after playing with it again, I couldn't reproduce with this:

class Comment < ActiveRecord::Base
  belongs_to :post

  named_scope :enabled, :conditions => { :enabled => true }
  named_scope :desktop,
              :joins => :post,
              :conditions => { "posts.name" => "desktop" }
end

class Post < ActiveRecord::Base
end

Calling Comment.enabled.desktop worked fine. Then, I tried with:

class Comment < ActiveRecord::Base
  belongs_to :cost

  named_scope :enabled, :conditions => { :enabled => true }
  named_scope :desktop,
              :joins => :cost,
              :conditions => { "costs.name" => "desktop" }
end

class Cost < ActiveRecord::Base
end

Then, calling Comment.enabled.desktop brings the SQL error.

I can't add a failing test patch without adding new models to the test suite. How should I proceed in this case?

Here's full models:

class Comment < ActiveRecord::Base
  belongs_to :cost
  belongs_to :post

  named_scope :enabled, :conditions => { :enabled => true }
  named_scope :cost_desktop,
              :joins => :cost,
              :conditions => { "costs.name" => "desktop" }
  
  named_scope :post_desktop,
              :joins => :post,
              :conditions => { "posts.name" => "desktop" }
end

class Cost < ActiveRecord::Base
end

class Post < ActiveRecord::Base
end

Here's schema:

ActiveRecord::Schema.define do
  create_table :comments, :force => true do |t|
    t.integer :post_id

    t.string :name
    t.boolean :enabled
  end

  create_table :costs, :force => true do |t|
    t.string :name
  end
  
  create_table :posts, :force => true do |t|
    t.string :name
  end
end

Calling Comment.enabled.post_desktop works, but Comment.enabled.cost_desktop doesn't.

Here's the SQL generated for Comment.enabled.post_desktop

SELECT `comments`.* FROM `comments` INNER JOIN `posts` ON `posts`.id = `comments`.post_id WHERE ((`comments`.`enabled` = 1 AND `posts`.`name` = 'desktop'))

And, here's the one generated for Comment.enabled.cost_desktop

SELECT `comments`.* FROM `comments` INNER JOIN `costs` ON `costs`.id = `comments`.cost_id WHERE ((`costs`.`name` = 'desktop' AND `costs`.`enabled` = 1))

Which gives me:

Mysql::Error: Unknown column 'costs.enabled' in 'where clause'

(from [0472839d684d836e1e7ecd39722c313410d76d5b]) Prevent overwriting of table name in merging SQL conditions [#2949 Add magic encoding comment to generated files state:resolved] http://github.com/rails/rails/commit/0472839d684d836e1e7ecd39722c31...

Automatic cleanup of spam.

Automatic cleanup of spam.

Automatic cleanup of spam.

Automatic cleanup of spam.

Automatic cleanup of spam.

gucci watches