Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

HTTP Digest authentication raise an exception if the client fails to include a nonce

#2968

The HTTP Digest authentication will raise an exception, and return a 500, if the client fails to include a nonce key/value in the Authorization header value. Rather than raise an exception it should simply return 401.

This also happens if the client specifies Basic authentication credentials. Again, it should return 401 rather than 500.

The fix is a single line check. Tests included.

Reported by Adam Milligan · July 28th, 2009 @ 11:51 PM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Michael Koziarski
    Michael Koziarski
    • Assigned user set to Michael Koziarski
    • Milestone set to 2.3.4

    July 29th, 2009 @ 02:48 AM

  2. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.4 to 2.3.6

    [milestone:id#50064 bulk edit command]

    September 11th, 2009 @ 11:04 PM

  3. CancelProfileIsBroken
    CancelProfileIsBroken
    • Tag changed from actionpack, digest, http_authentication, patch, tested to actionpack, bugmash, digest, http_authentication, patch, tested
    • Milestone cleared.
    • Assigned user cleared.

    September 25th, 2009 @ 01:01 PM

  4. Repository
    Repository
    • State changed from new to resolved

    (from [fdf356d74b9054d44f23356051dd3a85ee9a83b3]) Fixed HTTP digest to properly return 401 when the Authorization header has no nonce specified, or the Authorization header specifies Basic auth [#2968 HTTP Digest authentication raise an exception if the client fails to include ... state:resolved] http://github.com/rails/rails/commit/fdf356d74b9054d44f23356051dd3a...

    October 21st, 2009 @ 08:06 PM