Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Milligan's latest activity

Tuesday, September 29 2009
3259 Allow explicit placement of hidden fields with nested models was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 3:30 PM

    What about the destroy (née delete) hidden field? Does the form builder not also output that if the model is marked for destruction?

Thursday, September 10 2009
2993 First request will always have an empty body due to delayed load of action_co... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 3:41 AM

    Fjan, I'm pleased that this helped you out. My goal with things like this is to create a Google result for people who run into the same problem. If you're inter...

Thursday, August 06 2009
2993 First request will always have an empty body due to delayed load of action_co... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 2:40 AM

    Here you go. I worked from the 2-3-stable branch since all of the CGI stuff is gone in master.

Wednesday, August 05 2009
2984 Warn when parameters to functional test requests have improper values was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 1:07 AM

    Will, look about six messages up, I already gave an example. Here it is again:

    post :create, :person => { :age => 23 }
    

    Here's the controller:

    class PersonCon...
Tuesday, August 04 2009
2993 First request will always have an empty body due to delayed load of action_co... was created in Ruby on Rails
  • Adam Milligan
    Adam Milligan created the ticket at 8:06 AM

    After you restart a Mongrel server the first request will always fail to have the correct HTTP request body. The reason for this is the override of CGI#initiali...

Monday, August 03 2009
2989 Setting the id of a belongs_to object does not update the reference to the ob... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 9:28 PM

    I run into this bug about once a month, and it drives me up the wall. I patched it at one point, which created an infinite loop at validation time due to the fa...

Sunday, August 02 2009
2984 Warn when parameters to functional test requests have improper values was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 4:55 PM

    Integers are one of the most nefarious culprits in functional tests, so no, allowing integers is a terrible idea.

    In the case of non-path parameters:


    post :cre...

  • Adam Milligan
    Adam Milligan commented at 7:55 AM

    Apparently I fail at markdown. The link for the previous patch is https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...

  • Adam Milligan
    Adam Milligan created the ticket at 7:52 AM

    This is a replacement for the ticket here.

    In that previous ticket I made the argument that functional tests shouldn't allow passing parameters with values tha...

2970 Parameters to functional test requests should have proper values was updated in Ruby on Rails