Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Milligan's latest activity

Thursday, July 30 2009
2970 Parameters to functional test requests should have proper values was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 5:52 PM

    I didn't really expect this patch to be committed as is. However, the idea that Rails should automatically convert all of your test parameters to something oste...

Wednesday, July 29 2009
2970 Parameters to functional test requests should have proper values was created in Ruby on Rails
  • Adam Milligan
    Adam Milligan created the ticket at 3:33 AM

    How many times have you written this in a functional test:


    post :create, :wibble => { :dingledongle => 7 }

    It looks fine, and the test runs fine, but then you ...

Tuesday, July 28 2009
2968 HTTP Digest authentication raise an exception if the client fails to include ... was created in Ruby on Rails
  • Adam Milligan
    Adam Milligan created the ticket at 11:51 PM

    The HTTP Digest authentication will raise an exception, and return a 500, if the client fails to include a nonce key/value in the Authorization header value. Ra...

1267 Methods invoked within named_scope Procs should respect the scope stack was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 5:29 PM

    I have to agree with Joseph. This change significantly effects the behavior of existing named scopes, and it's not clear what the original motivation is. Changi...

Saturday, July 04 2009
2765 after_create callback not working as it should was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 9:16 PM

    After a little more investigation I take back my previous comment. Something very odd is happening here.

  • Adam Milligan
    Adam Milligan commented at 7:47 PM

    This is not a bug. You're getting two Linkage records added to the database because when you create a Foo model with an associated Bar model Rails creates the j...

Wednesday, May 13 2009
1642 HasOneThroughAssociation should not be a child of HasManyThroughAssociation was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 4:13 PM

    1) Please take a look at activerecord/lib/active_record/associations.rb, line 1236. This is the code that defies the association setter method for all associati...

Monday, May 11 2009
1642 HasOneThroughAssociation should not be a child of HasManyThroughAssociation was updated in Ruby on Rails
  • Adam Milligan
    • Assigned user set to Jeremy Kemper
    • Tag changed from activerecord, associations, has_one_through, patch to activerecord, associations, has_one_through, patch, refactoring
    by Adam Milligan at 12:34 AM

    Based on the discussion at RailsConf I'm pressing for this refactoring once more. I've reapplied the changes to the current HEAD of Rails and recreated the patc...

Monday, March 09 2009
1642 HasOneThroughAssociation should not be a child of HasManyThroughAssociation was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 6:38 AM

    To put not too fine a point on it, this is a fundamentally improper use of inheritance; the relationship exists to share implementation rather than interface. R...

Tuesday, February 10 2009
1913 Use #to_param in generated controller tests. was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 12:51 AM

    +1

    The whole "it's called an ID but it's not an ID" thing is confusing enough as it is. No need to make it worse by generating wrong code.