Adam Milligan
Developer · Not a member
Adam Milligan's latest activity
Friday, January 16 2009
-
Adam Milligan commented at 3:47 PMHTML provides the definition list for exactly this scenario. Using dl/dt/dd seems more appropriate than either p or fieldset.
Sunday, December 28 2008
-
Adam Milligan commented at 11:03 PMI've submitted a fix for this problem in this ticket. However, upon reflection, I think I like Koz's suggestions better. The target object should respond corre...
-
Adam Milligan commented at 1:50 AMA fairly trivial amount of investigation made clear that #include? isn't going to cut it, performance-wise. Here is a new patch with a small change. Basically, ...
Saturday, December 27 2008
-
- Tag changed from actionview, helper to actionview, helper, patch, tested
I agree with Josh and Arthur that the correct behavior would be setting the class attribute on the invalid input element. I also believe that there's no time li...
-
Adam Milligan commented at 7:34 PMI realize I'm late to the party on this, but this is behavior we've seen at Pivotal a number of times now on a number of different projects. I've made the probl...
-
Adam Milligan created the ticket at 8:24 AMThe has_many_through_associations_test.rb file has a test that fails only when running this file individually, rather than as part of the ActiveRecord test suit...
-
Adam Milligan created the ticket at 8:22 AMThis patch: http://rails.lighthouseapp.com/p... changed association proxies so they will not respond to private methods. However, they also now will not respon...
-
Adam Milligan created the ticket at 8:16 AMThis patch changes the superclass of HasOneThroughAssociation to HasOneAssociation, moves the functionality shared between the two Through associations to a mod...
Thursday, December 25 2008
-
Adam Milligan commented at 3:45 PMI should have been more clear. When I wrote "what is the expected behavior for" I meant "there is no test for."
Wednesday, December 24 2008
-
Adam Milligan commented at 3:10 PMIn my opinion, "extended" isn't a particularly descriptive option name for this behavior. Something like "include_error_components" or "skip_message_agglomerati...