Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Milligan's latest activity

Friday, January 16 2009
1760 in scaffold templates, change paragraph tags to fieldset tags was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 3:47 PM

    HTML provides the definition list for exactly this scenario. Using dl/dt/dd seems more appropriate than either p or fieldset.

Sunday, December 28 2008
1083 Calls to private methods via association proxies should act consistently with... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 11:03 PM

    I've submitted a fix for this problem in this ticket. However, upon reflection, I think I like Koz's suggestions better. The target object should respond corre...

1643 Association proxies should correctly respond to method defined via #method_mi... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 1:50 AM

    A fairly trivial amount of investigation made clear that #include? isn't going to cut it, performance-wise. Here is a new patch with a small change. Basically, ...

Saturday, December 27 2008
1626 fieldWithErrors shouldn't use a div was updated in Ruby on Rails
  • Adam Milligan
    • Tag changed from actionview, helper to actionview, helper, patch, tested
    by Adam Milligan at 9:56 PM

    I agree with Josh and Arthur that the correct behavior would be setting the class attribute on the invalid input element. I also believe that there's no time li...

1109 object allocation during garbage collection phase was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 7:34 PM

    I realize I'm late to the party on this, but this is behavior we've seen at Pivotal a number of times now on a number of different projects. I've made the probl...

1644 Minor refactorings and order-dependent test failure fix was created in Ruby on Rails
  • Adam Milligan
    Adam Milligan created the ticket at 8:24 AM

    The has_many_through_associations_test.rb file has a test that fails only when running this file individually, rather than as part of the ActiveRecord test suit...

1643 Association proxies should correctly respond to method defined via #method_mi... was created in Ruby on Rails
1642 HasOneThroughAssociation should not be a child of HasManyThroughAssociation was created in Ruby on Rails
  • Adam Milligan
    Adam Milligan created the ticket at 8:16 AM

    This patch changes the superclass of HasOneThroughAssociation to HasOneAssociation, moves the functionality shared between the two Through associations to a mod...

Thursday, December 25 2008
1625 Allow active record errors to_xml to return separate tags for attribute and m... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 3:45 PM

    I should have been more clear. When I wrote "what is the expected behavior for" I meant "there is no test for."

Wednesday, December 24 2008
1625 Allow active record errors to_xml to return separate tags for attribute and m... was updated in Ruby on Rails
  • Adam Milligan
    Adam Milligan commented at 3:10 PM

    In my opinion, "extended" isn't a particularly descriptive option name for this behavior. Something like "include_error_components" or "skip_message_agglomerati...