This project is archived and is in readonly mode.
problem with cookie escaping on integration tests
-
CancelProfileIsBroken
- Tag changed from cookies, integration_test to bugmash, cookies, integration_test
-
John Pignata
-1 - cannot verify this bug. Trying to verify with the following test:
class CookieTest < ActionController::IntegrationTest def setup @cookie_data = { :remember_me => '1;abcdefg' } cookies.merge!(@cookie_data) end test "cookie escaping" do p cookies assert_equal(@cookie_data, cookies) end end -
Elomar França
This bug cannot be verified on 2-3-stable, only on master, but I am almost sure it's a bug from rack-test 0.5.0 as 2-3-stable doesn't use it.
In Integration::Session, the method "cookies" returns the cookie_jar from an instance of Rack::Test::Session, defined on rack-test.
-
John Pignata
Elomar is correct - I can replicate on master.
The following code is in rack-test/rack/test/cookie_jar.rb:
def []=(name, value) # TODO: needs proper escaping merge("#{name}=#{value}") endThis ticket can be closed.
-
CancelProfileIsBroken
- Tag changed from bugmash, cookies, integration_test to cookies, integration_test
- State changed from new to invalid
Filed under "not our problem".
-
Matías Flores
- Tag changed from cookies, integration_test to cookies, integration_test
not reproducible on 2-3-stable. Elomar is right.