This project is archived and is in readonly mode.
In databases.rake, drop_database missing else-clause
-
CancelProfileIsBroken- Tag changed from 2.3.4, db:drop, rake to 2.3.4, bugmash, db:drop, rake
-
Daniel Hofstetter
-
databases.rake.diff
892 Bytes
-
-
Daniel Hofstetter
The patch adds the missing else-clause and raises an error in it.
-
Daniel Hofstetter
- Tag changed from 2.3.4, bugmash, db:drop, rake to 2.3.4, bugmash, bugmash-patch, bugmash-review, db:drop, rake
-
-
Blue Box Jesse+1
2.3-stable patch applies successfully.
Good idea and good fix.
-
Anuj Dutta+1
Applies successfully.
-
CancelProfileIsBroken
- Tag changed from 2.3.4, bugmash, bugmash-patch, bugmash-review, db:drop, rake to 2.3.4, bugmash-patch, bugmash-review, db:drop, rake
-
Lenary- Tag changed from 2.3.4, bugmash-patch, bugmash-review, db:drop, rake to 2.3.4, bugmash-patch, bugmash-review, db:drop, patch, rake
-
Lenary
- Tag changed from 2.3.4, bugmash-patch, bugmash-review, db:drop, patch, rake to 2.3.4, bugmash-patch, bugmash-review, db:drop, incomplete, rake
There seems to be no reason why this has not yet been fixed.
In the meantime though, the problem still persists, but the files have moved quite a lot.
the file you are all referring to is now located here in rails 3:
http://github.com/rails/rails/blob/master/activerecord/lib/active_r...
(i have not evaluated the patches for correctness or otherwise)
good fix though!
-
-
Rizwan Reza- Tag changed from 2.3.4, bugmash-patch, bugmash-review, db:drop, incomplete, rake to 2.3.4, bugmash, bugmash-patch, db:drop, incomplete, rake
-
Diego Algortaverified
Submitting updated patch for rails master
-
master-databasesrake.diff
963 Bytes
-
-
Diego Algorta
Submitting patch for 2-3-stable too. Original Author maintained.
-
2-3-stable-databasesrake.diff
955 Bytes
-
-
Jeff Kreeftmeijer
-1
This should have some tests if you ask me.
-
Jeff Kreeftmeijer
Sorry, that should've been a "+". I completely agree with this patch, I just think it needs some tests. :)
-
Santiago Pastorino
- State changed from new to open
- Tag changed from 2.3.4, bugmash, bugmash-patch, db:drop, incomplete, rake to 234, bugmash, bugmash-patch, dbdrop, incomplete, rake
- Importance changed from to
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale