This project is archived and is in readonly mode.
[PATCH] Parameter Filtering Blows up with Fixnum values
When receiving an XML payload, filter_parameters can receive parameter values that are already typecast. If those values are Fixnums or other objects that throw an error when sent #dup, then an exception is thrown and since it's in logging it will typically not make it out to exception notification.
A working patch with a test is attached.
-
fix_filter_parameters.diff
1.72 KB
-
Duff OMelia+1
-
Repository- State changed from new to committed
(from [ab9efe9e165ea1e8a8dc37287deea4439d3fbc05]) Fix filtering parameters when there are Fixnum or other un-dupable values.
[#3184 [PATCH] Parameter Filtering Blows up with Fixnum values state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/ab9efe9e165ea1e8a8dc37287deea4... -
Repository
(from [f024aabee37520e8c894a83710fc121c0056dd2b]) Fix filtering parameters when there are Fixnum or other un-dupable values.
[#3184 [PATCH] Parameter Filtering Blows up with Fixnum values state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/f024aabee37520e8c894a83710fc12... -
Jeremy Kemper(tweaked to use duplicable? rather than rescue)
-
Nathaniel TalbottExcellent - didn't know about #duplicable?. Thanks Jeremy!