This project is archived and is in readonly mode.
[PATCH] Parameter Filtering Blows up with Fixnum values
Reported by Nathaniel Talbott | September 11th, 2009 @ 02:22 AM
When receiving an XML payload, filter_parameters can receive parameter values that are already typecast. If those values are Fixnums or other objects that throw an error when sent #dup, then an exception is thrown and since it's in logging it will typically not make it out to exception notification.
A working patch with a test is attached.
Comments and changes to this ticket
-
Repository September 11th, 2009 @ 03:21 AM
- State changed from new to committed
(from [ab9efe9e165ea1e8a8dc37287deea4439d3fbc05]) Fix filtering parameters when there are Fixnum or other un-dupable values.
[#3184 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/ab9efe9e165ea1e8a8dc37287deea4... -
Repository September 11th, 2009 @ 03:21 AM
(from [f024aabee37520e8c894a83710fc121c0056dd2b]) Fix filtering parameters when there are Fixnum or other un-dupable values.
[#3184 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/f024aabee37520e8c894a83710fc12... -
Nathaniel Talbott September 11th, 2009 @ 03:36 AM
Excellent - didn't know about #duplicable?. Thanks Jeremy!
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 3184 [PATCH] Parameter Filtering Blows up with Fixnum values [#3184 state:committed]
- 3184 [PATCH] Parameter Filtering Blows up with Fixnum values [#3184 state:committed]