This project is archived and is in readonly mode.
Add read_multi to ActiveSupport::Cache::Store
I currently run unit tests with MemoryStore, and production with MemCacheStore. I use the 'read_multi' method provided by MemCacheStore, but read_multi is only available to MemCacheStore, so the code breaks in tests.
I realize that I can fix my tests by always using :memcache_store, and wrapping every test using 'with_local_cache' (defined in ActiveSupport::Cache::Strategy::LocalCache). However, this method is not documented, and I'm not sure if developers should be using this. If I'm testing incorrectly, this ticket is awash.
This patch adds 'read_multi' to the Rails.cache API. It duplicates the memcache behavior in that the arguments are flattened, and nonexistent keys are not included in the results.
-
read_multi_for_all_caches.diff
2.07 KB
-
CancelProfileIsBroken- Tag changed from active_support to active_support, bugmash
-
John Pignata
+1 on the change, verified that patch applies cleanly to master and tests pass
-
Prem Sichanugrist (sikachu)- State changed from new to open
- Assigned user set to José Valim
+1 on this patch.
However, I found out that
CompressedMemCacheStoretests doesn't work after apply your patch. So here's my another patch that adds documentation and properread_multitoCompressedMemCacheStoreYou need to apply
matthuhigginspatch, then my patch :) Both of them can be applied on2-3-stableandmaster -
Rizwan Reza- Tag changed from active_support, bugmash to active_support
-
José Valim- Assigned user changed from José Valim to Jeremy Kemper
I have limited knowledge on cache stores, so I can't tell what is the proper fix. Assigning to Jeremy.
-
